Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Fix" langchain user warning #12733

Merged
merged 1 commit into from
Aug 16, 2023
Merged

"Fix" langchain user warning #12733

merged 1 commit into from
Aug 16, 2023

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Aug 15, 2023 •
edited
Loading

Proposed changes:

  • ignore the warning, the framework sucks and actually you can't create an instance in that place without encountering the warning...

fixes https://rasa-hq.slack.com/archives/C05KCQDV8PJ/p1692012866420379

@tmbo tmbo requested a review from a team as a code owner August 15, 2023 08:25
@tmbo tmbo requested review from twerkmeister and removed request for a team August 15, 2023 08:25
twerkmeister
twerkmeister approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm that it does not seem possible to get around that warning using their generic factory

@tmbo tmbo merged commit 444fc60 into dm2 Aug 16, 2023
95 of 96 checks passed
@tmbo tmbo deleted the fix-langchain-user-warning branch August 16, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twerkmeister twerkmeister twerkmeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmbo @twerkmeister