Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lay groundwork for cross-platform login #750

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

ericbolikowski
Copy link
Contributor

What Github issue does this PR relate to? Insert link.

#706

What should the reviewer know?

This PR re-enables the cross-platform (or, cross-product) functionality that was disabled when the Salesforce integration went live.

Work in the PR so far (Eric, 8 June 2023) relies on the data fetcher functions used in the CON and TP frontends being differentiated: data fetchers used by CON (via the react-query hooks used by CON) will include a "Redi-Product: CON" header in requests to nestjs. Same for TP.

Copy link
Contributor Author

@ericbolikowski ericbolikowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Eric, Kate, looks good!

@ericbolikowski ericbolikowski marked this pull request as ready for review June 9, 2023 10:51
@ericbolikowski ericbolikowski merged commit 191ca57 into master Jun 9, 2023
@ericbolikowski ericbolikowski deleted the feat/cross-platform-login branch June 9, 2023 10:51
@katamatata katamatata linked an issue Jun 12, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CON/TP/Log-in]: Re-implement cross-platform log-in
1 participant