-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TooltipControllerTypes.d.ts #1202
base: master
Are you sure you want to change the base?
Conversation
Allow JSX.Element in tooltip content and html props - Update ITooltipController interface - content and html props now accept string | JSX.Element - Improves flexibility for adding React elements in TypeScript
WalkthroughThe Changes
Sequence Diagram
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/components/TooltipController/TooltipControllerTypes.d.ts (1 hunks)
Files not reviewed due to errors (1)
- src/components/TooltipController/TooltipControllerTypes.d.ts (no review received)
I'll have to check if this doesn't break anything (we might assume <Tooltip>
<MyTooltipContent />
</Tooltip> We're already doing some planning for V6 of the tooltip, so we might integrate this, or just drop the Not sure yet what we'll do, but thanks for the suggestion! |
This pull request is stale because it has not seen activity in 30 days. Remove the |
Allow JSX.Element in tooltip content and html props
Summary by CodeRabbit