Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] remove cigatingMessage.groovy #176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

patchkez
Copy link
Contributor

No description provided.

quarckster
quarckster previously approved these changes Mar 28, 2022
@Victoremepunto
Copy link
Collaborator

I believe @quarckster is already familiar with this PR - but me personally I don't know the impact of this removal, what was this code used for, and what is the reason for it's removal (like, deprecation, or just dead code removal that was deferred for too much time) ? - In other words, can @patchkez , @quarckster please add some content to the PR description, for future reference ?

@patchkez
Copy link
Contributor Author

@Victoremepunto ciGatingMessage was used to manipulate UMB messages needed for OSCI Gating. I believe this was used only by our team, because of insights-client/rhc/rhc-worker playbook RPM release process. There is also clientUtils.groovy which I would like to remove (did not hear from our colleagues if anyone is using these in their pipelines), as these functions was used for setting up virtual machine before running insights-client/rhc* tests. We moved this code to internal repository. I hope I answered your questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants