Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Storing groceries changes #923

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Draft] Storing groceries changes #923

wants to merge 1 commit into from

Conversation

LeroyR
Copy link
Member

@LeroyR LeroyR commented Nov 25, 2024

** Note: Your contribution is expected to meet the conventions and policies described in the contribution guidelines **

Description

Example how to incorporate pouring in storing groceries.
IMHO Storing groceries is a more flexible task than Serving Breakfast and should be kept for stage 1.

This show some possible additions to make the task more interesting:

  • Pouring Milk/Cornflakes into container
    • Containers are placed on the table.
      • Container could be inside cabinet so that the robot has to take them out first
  • Grasping objects from a shopping bag
    • placed next to table.
      • Could also be on the table

@LeroyR LeroyR changed the title improved storing groceries Pouring in storing groceries Nov 25, 2024
@johaq
Copy link
Member

johaq commented Nov 25, 2024

I like this idea since it preserves two kinds of placing challenges, placing on a table AND placing inside a shelf. My questions is should we increase the time limit for this test? Potentially 7:30 instead of 5:00.

Copy link
Contributor

@hawkina hawkina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I like the changes and the combination.
One question: is the container for the cornflakes going to be transparent? If so, then it might add an additional difficulty for perception and we might consider rewarding it/ giving alternative options. Or just let people know in advance so that they know to train for transperency.


\scoreheading{Bonus Rewards}
\scoreitem{200}{Opening the cabinet door without human help}
\scoreitem{50}{Picking up an object from the shopping bag}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to also give 70 points here since it is more difficult. It is comparable to picking up the tiny/heavy objects.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the overall scores later. For now this is just to get the different score items into the rulebook

@@ -52,9 +56,11 @@ \subsection*{Procedure}
\begin{itemize}
\item whether the cabinet door should be closed
\item whether a heavy and/or a tiny object should be used in the test
\item whether the robot plans to pour the milk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about cereal?

Copy link
Member Author

@LeroyR LeroyR Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a main goal the cereal should always be present

@hawkina
Copy link
Contributor

hawkina commented Dec 1, 2024

I like this idea since it preserves two kinds of placing challenges, placing on a table AND placing inside a shelf. My questions is should we increase the time limit for this test? Potentially 7:30 instead of 5:00.

I would vote for increasing the time limit to 7:30 mins.

@LeroyR
Copy link
Member Author

LeroyR commented Dec 2, 2024

This is just a draft to show possible integrations. Details like scoring, container (where it is placed: inside cabinet so the robot has to take it out first or on the table) and time limit need further discussion.


I like this idea since it preserves two kinds of placing challenges, placing on a table AND placing inside a shelf. My questions is should we increase the time limit for this test? Potentially 7:30 instead of 5:00.

I put it to 6:00 in the initial draft to accommodate pouring the cereals. Going up to 7:30 is also fine.

I'd also like to introduce either a bonus for the first item or a decreasing score for each additional item - f the robot stores two items it should be able to store more anyway with time being the limiting factor. The space inside the cabinet was not really limited (At least until we require storing items efficiently e.g. by stacking cans)

So my question is: Are 6 minutes not enough for a ~slow robot to get to the location, scan the shelf, pour cornflakes and store one item (add potentially opening the door as main goal). Faster robots can then store multiple objects to collect additional points.

Another open question: Do we still want this kind of opening the door?

@sunava
Copy link
Contributor

sunava commented Dec 9, 2024

Here's a rewritten version for the PR comment:

  • Johannes: Suggests adding extra time since very few teams managed to pick up all 5 objects.
  • Luis & Vanessa: Propose keeping the "storing groceries" task as it is, possibly adding time, and including the "pouring" task in Stage 2.
  • Alina: Supports the idea but prefers to focus on keeping "pouring" included due to limited available time.
  • Akinobu: Agrees with adding extra time and keeping "pouring" in Stage 2.

So, closing this for now.

@sunava sunava closed this Dec 9, 2024
@LeroyR
Copy link
Member Author

LeroyR commented Dec 10, 2024

There is still ongoing discussion in this DRAFT, i dont see rationale for closing (just rename to storing grocerie changes)

Summary until now:

  • Multiple Suggestion to add extra time, even though we have a team finishing everything in 3 minutes
  • No mention of opening door changes or using bag as bin picking
  • Meeting Discussion: Dont do Pouring here, instead combine SB with cleanup

@LeroyR LeroyR reopened this Dec 10, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChkTeX Action

There are issues with your code. 😔 Check the annotations under the Files changed tab.

@LeroyR LeroyR changed the title Pouring in storing groceries Storing groceries changes Dec 10, 2024
@LeroyR LeroyR changed the title Storing groceries changes [Draft] Storing groceries changes Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants