-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Storing groceries changes #923
base: master
Are you sure you want to change the base?
Conversation
I like this idea since it preserves two kinds of placing challenges, placing on a table AND placing inside a shelf. My questions is should we increase the time limit for this test? Potentially 7:30 instead of 5:00. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I like the changes and the combination.
One question: is the container for the cornflakes going to be transparent? If so, then it might add an additional difficulty for perception and we might consider rewarding it/ giving alternative options. Or just let people know in advance so that they know to train for transperency.
|
||
\scoreheading{Bonus Rewards} | ||
\scoreitem{200}{Opening the cabinet door without human help} | ||
\scoreitem{50}{Picking up an object from the shopping bag} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to also give 70 points here since it is more difficult. It is comparable to picking up the tiny/heavy objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the overall scores later. For now this is just to get the different score items into the rulebook
@@ -52,9 +56,11 @@ \subsection*{Procedure} | |||
\begin{itemize} | |||
\item whether the cabinet door should be closed | |||
\item whether a heavy and/or a tiny object should be used in the test | |||
\item whether the robot plans to pour the milk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about cereal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a main goal the cereal should always be present
I would vote for increasing the time limit to 7:30 mins. |
This is just a draft to show possible integrations. Details like scoring, container (where it is placed: inside cabinet so the robot has to take it out first or on the table) and time limit need further discussion.
I put it to 6:00 in the initial draft to accommodate pouring the cereals. Going up to 7:30 is also fine. I'd also like to introduce either a bonus for the first item or a decreasing score for each additional item - f the robot stores two items it should be able to store more anyway with time being the limiting factor. The space inside the cabinet was not really limited (At least until we require storing items efficiently e.g. by stacking cans) So my question is: Are 6 minutes not enough for a ~slow robot to get to the location, scan the shelf, pour cornflakes and store one item (add potentially opening the door as main goal). Faster robots can then store multiple objects to collect additional points. Another open question: Do we still want this kind of opening the door? |
Here's a rewritten version for the PR comment:
So, closing this for now. |
There is still ongoing discussion in this DRAFT, i dont see rationale for closing (just rename to storing grocerie changes) Summary until now:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChkTeX Action
There are issues with your code. 😔 Check the annotations under the Files changed tab.
** Note: Your contribution is expected to meet the conventions and policies described in the contribution guidelines **
Description
Example how to incorporate pouring in storing groceries.
IMHO Storing groceries is a more flexible task than Serving Breakfast and should be kept for stage 1.
This show some possible additions to make the task more interesting: