Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ign packages to linux #146

Merged
merged 26 commits into from
Mar 1, 2024
Merged

Conversation

raghavauppuluri13
Copy link
Contributor

No description provided.

@wolfv
Copy link
Member

wolfv commented Jun 11, 2021

looks like the ign package doesn't exist?

@raghavauppuluri13
Copy link
Contributor Author

It was listed in the package list , should that be removed?

@traversaro
Copy link
Member

I think that package is ros-ign, ros-ign-bridge, and so on so forth.

@raghavauppuluri13
Copy link
Contributor Author

Ah. That'll do it. Thanks @traversaro

@Tobias-Fischer
Copy link
Collaborator

Triggered the build - let's see what happens.

@Tobias-Fischer
Copy link
Collaborator

Seems like osx is failing - check patch/add_dependencies.yaml and add gtest for the failing package.

@Tobias-Fischer
Copy link
Collaborator

Same error on Windows..

@Tobias-Fischer
Copy link
Collaborator

Any clue why the ci doesn't get triggered @wolfv?

@wolfv wolfv closed this Jun 12, 2021
@wolfv wolfv reopened this Jun 12, 2021
@Tobias-Fischer
Copy link
Collaborator

ign-gazebo is currently not build for OSX and win, see conda-forge/libignition-gazebo-feedstock#2

@Tobias-Fischer
Copy link
Collaborator

Cc @traversaro

@Tobias-Fischer Tobias-Fischer changed the title add ign packages to osx and win add ign packages to win Jul 22, 2021
@Tobias-Fischer
Copy link
Collaborator

Tobias-Fischer commented Jul 22, 2021

This now fails because of incompatible ign versions - we are overwriting gazebo3 (citadel) with gazebo5 (edifice) as this is the first available version for win on conda-forge, but would need to do the same for transport & msgs (map from citadel to edifice). Any objections against this weird mapping?

We should probably just do this for all platforms ..

@Tobias-Fischer
Copy link
Collaborator

This now fails because ros-noetic-pluginlib-1.13.0-py38h508dd2d_5 needs tinyxml2=8 ..

@Tobias-Fischer
Copy link
Collaborator

We probably need a full rebuild here, too :(

@traversaro
Copy link
Member

This now fails because of incompatible ign versions - we are overwriting gazebo3 (citadel) with gazebo5 (edifice) as this is the first available version for win on conda-forge, but would need to do the same for transport & msgs (map from citadel to edifice). Any objections against this weird mapping?

We should probably just do this for all platforms ..

Ok for me. When everything works and the amount of fixes is reduced, we can think of using the LTS (perhaps Fortress, see https://ignitionrobotics.org/docs/all/releases) or having alternatives, but for the time being just using the latest make more sense.

@Tobias-Fischer Tobias-Fischer changed the title add ign packages to win add ign packages to win (needs rebuild) Sep 20, 2021
@Tobias-Fischer
Copy link
Collaborator

Hi @traversaro - just to confirm, this PR won’t be possible as Noetic only works with Fortress, but we don’t build Fortress for Windows anymore?

@traversaro
Copy link
Member

Hi @traversaro - just to confirm, this PR won’t be possible as Noetic only works with Fortress, but we don’t build Fortress for Windows anymore?

Yes, I am afraid unless we make sure that Fortress packages works on Windows, this PR can't work.

@Tobias-Fischer
Copy link
Collaborator

Ok thanks Silvio! I assume getting things to work won’t be trivial, so let’s close here. If there are interested people we could guide them in the right direction.

@Tobias-Fischer Tobias-Fischer changed the title add ign packages to win (needs rebuild) add ign packages to linux Mar 1, 2024
@Tobias-Fischer Tobias-Fischer merged commit c06cdce into RoboStack:main Mar 1, 2024
5 checks passed
@Tobias-Fischer
Copy link
Collaborator

Hi @raghavauppuluri13 - feel free to let us know if you are still interested in this for Windows - we can point you in the right direction if you would like to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants