jcabi#7 - base32-encode H2 table names to support all possible Dynamo…

…DB names
RomanKisilenko · Jan 17, 2015 · 616482f · 616482f
1 parent 3fd48e8
commit 616482f
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 5 deletions.
diff --git a/pom.xml b/pom.xml
@@ -117,6 +117,10 @@
             <artifactId>commons-lang3</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>commons-codec</groupId>
+            <artifactId>commons-codec</artifactId>
+        </dependency>
     </dependencies>
     <build>
         <pluginManagement>

diff --git a/src/main/java/com/jcabi/dynamo/mock/H2Data.java b/src/main/java/com/jcabi/dynamo/mock/H2Data.java
@@ -57,6 +57,7 @@
 import java.util.Properties;
 import lombok.EqualsAndHashCode;
 import lombok.ToString;
+import org.apache.commons.codec.binary.Base32;
 import org.h2.Driver;
 
 /**
@@ -71,7 +72,7 @@
 @ToString
 @Loggable(Loggable.DEBUG)
 @EqualsAndHashCode(of = "jdbc")
-@SuppressWarnings("PMD.TooManyMethods")
+@SuppressWarnings({ "PMD.TooManyMethods", "PMD.ExcessiveImports" })
 public final class H2Data implements MkData {
 
     /**
@@ -170,8 +171,9 @@ public H2Data(final File file) {
     public Iterable<Attributes> iterate(final String table,
         final Conditions conds) throws IOException {
         try {
+            final String h2Table = this.encodeTableName(table);
             final StringBuilder sql = new StringBuilder("SELECT * FROM ")
-                .append(table);
+                .append(h2Table);
             if (!conds.isEmpty()) {
                 sql.append(" WHERE ");
                 Joiner.on(" AND ").appendTo(
@@ -204,18 +206,20 @@ public Iterable<Attributes> iterate(final String table,
             throw new IOException(ex);
         }
     }
+
     @Override
     public void put(final String table, final Attributes attrs)
         throws IOException {
         try {
+            final String h2Table = this.encodeTableName(table);
             JdbcSession session = new JdbcSession(this.connection());
             for (final AttributeValue value : attrs.values()) {
                 session = session.set(H2Data.value(value));
             }
             session.sql(
                 String.format(
                     "INSERT INTO %s (%s) VALUES (%s)",
-                    table,
+                    h2Table,
                     Joiner.on(',').join(attrs.keySet()),
                     Joiner.on(',').join(Collections.nCopies(attrs.size(), "?"))
                 )
@@ -231,6 +235,7 @@ public void update(final String table, final Attributes keys,
         final AttributeUpdates attrs)
         throws IOException {
         try {
+            final String h2Table = this.encodeTableName(table);
             JdbcSession session = new JdbcSession(this.connection());
             for (final AttributeValueUpdate value : attrs.values()) {
                 session = session.set(H2Data.value(value.getValue()));
@@ -241,7 +246,7 @@ public void update(final String table, final Attributes keys,
             session.sql(
                 String.format(
                     "UPDATE %s SET %s WHERE %s",
-                    table,
+                    h2Table,
                     Joiner.on(',').join(
                         Iterables.transform(attrs.keySet(), H2Data.WHERE)
                     ),
@@ -271,8 +276,9 @@ public H2Data with(final String table, final String[] keys,
                 String.format("empty list of keys for %s table", table)
             );
         }
+        final String h2Table = this.encodeTableName(table);
         final StringBuilder sql = new StringBuilder("CREATE TABLE ")
-            .append(table).append(" (");
+            .append(h2Table).append(" (");
         Joiner.on(',').appendTo(
             sql,
             Iterables.transform(Arrays.asList(keys), H2Data.CREATE_KEY)
@@ -319,4 +325,13 @@ private static String value(final AttributeValue attr) {
         return val;
     }
 
+    /**
+     * Base32-encodes table name for use with H2.
+     * @param table Table name to encode
+     * @return Base-32-encoded table name
+     */
+    private String encodeTableName(final String table) {
+        return new Base32(true, (byte) '_').encodeAsString(table.getBytes());
+    }
+
 }
diff --git a/src/test/java/com/jcabi/dynamo/mock/H2DataTest.java b/src/test/java/com/jcabi/dynamo/mock/H2DataTest.java
@@ -30,9 +30,11 @@
 package com.jcabi.dynamo.mock;
 
 import com.amazonaws.services.dynamodbv2.model.AttributeValue;
+import com.google.common.base.Joiner;
 import com.jcabi.dynamo.Attributes;
 import com.jcabi.dynamo.Conditions;
 import java.io.File;
+import java.util.Collections;
 import org.hamcrest.MatcherAssert;
 import org.hamcrest.Matchers;
 import org.junit.Ignore;
@@ -111,4 +113,19 @@ public void createsManyTables() throws Exception {
             .with("secondtable", new String[]{"secondid"}, new String[0]);
     }
 
+    /**
+     * H2Data can create tables with long names (max length of DynamoDb table
+     * name is 255 characters).
+     * @throws Exception In case test fails
+     */
+    @Test
+    public void createsTablesWithLongNames() throws Exception {
+        new H2Data()
+            .with(
+                //@checkstyle MagicNumberCheck (1 line)
+                Joiner.on("").join(Collections.nCopies(255, "a")),
+                new String[] {"key"}, new String[0]
+        );
+    }
+
 }