Support more sample formats and endianness #690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is nice, but first we need to get #689 merged. |
|
Agreed and I'm working on it. But I wanted to collect some feedback in parallel. |
catch more unsupported sample formats
catch more unsupported sample formats
remove unused imports
|
I found a cleaner solution to solve this. I'll re-start with another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for adding more sample formats and endianness-awareness to cpal. The current version has been prepared to support all byte-aligned sample types but so far I only implemented
i/u(8, 16, 32, 64)andf(32, 64). I will add more of them (i/u24) shortly if there is a consensus that this approach will be accepted.Likely fixes #414, fixes #662, fixes #488 fixes #396
This PR would deprecate: #420, #531
The PR #689 is included.