Restore "p521: fiat-constify update (#1003)" #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 26be150. Now that we've completed the `elliptic-curve` v0.14.0-pre upgrade, we can restore the fiat-crypto upgrade. This commit takes a slightly different approach and puts the macro implementation for the newest version of `fiat-crypto` into the new `primefield` crate which was added in #1013. The goal will be to update all of the crates and then remove the old macros from `primeorder` entirely.
tarcieri
force-pushed
the
p521/restore-fiat-crypto-upgrade
branch
from
e37b5ad to
0ba7085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 26be150.
Now that we've completed the
elliptic-curvev0.14.0-pre upgrade, we can restore the fiat-crypto upgrade.This commit takes a slightly different approach and puts the macro implementation for the newest version of
fiat-cryptointo the newprimefieldcrate which was added in #1013.The goal will be to update all of the crates and then remove the old macros from
primeorderentirely.cc @MasterAwesome