sm2: add SM2PKE support #1069
sm2: add SM2PKE support #1069
Conversation
heliannuuthus
commented
Aug 12, 2024
•
heliannuuthus
commented
- encrypt
- decrypt
- encrypt_der
- decrypt_der
heliannuuthus
force-pushed
the
feat-sm2pke
branch
2 times, most recently
from
a6274c3 to
0f943a3
Compare
|
Looks great on a first pass. I'll try to do a more in-depth pass soon. |
heliannuuthus
force-pushed
the
feat-sm2pke
branch
from
b67aaef to
e52f48b
Compare
| // // If 𝑡 is an all-zero bit string, go to A1. | ||
| // if all of t are 0, xor(c2) == c2 |
There was a problem hiding this comment.
This comment seems a little odd
There was a problem hiding this comment.
I want to explain why we need to determine that xor(c2) == c2，but the description seems odd
There was a problem hiding this comment.
At the very least, there's a double // //
It seems like If 𝑡 is an all-zero bit string and if all of t are 0 describe the same condition in slightly different ways.
| let mut ct: i32 = 0x00000001; | ||
| let mut offset = 0; | ||
| let digest_size = hasher.output_size(); | ||
| let mut ha = vec![0u8; digest_size]; |
There was a problem hiding this comment.
This won't work on heapless no_std targets, nor is the alloc feature being enabled by the pke feature.
It seems like you could get rid of these dynamic allocations if you switched from DynDigest to a generic D parameter like you have for decrypt_digest and bound on the OutputSizeUser trait, which will give you access to a compile-time output size which can be used to allocate an appropriately sized array.
There was a problem hiding this comment.
I once saw an issue related to using OutputSizeUser::USIZE to create a new array.
There was a problem hiding this comment.
I once saw an issue related to using
OutputSizeUser::USIZEto create a new array.
I tried to solve this problem with the hybird_array, but I needed a little time to adjust the other places where the alloc feature was used
| kdf(hasher, c1_point, &mut c2)?; | ||
|
|
||
| // compute 𝑢 = 𝐻𝑎𝑠ℎ(𝑥2 ∥ 𝑀′∥ 𝑦2). | ||
| let mut u = vec![0u8; digest_size]; |
There was a problem hiding this comment.
Similar comment to this one regarding the dynamic allocations. They're unnecessary.
