p521: Improve Debug for unsaturated math
#949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using p521, the limbs can be populated differently which when deriving [`Debug`] shows up as different values for equal FieldElements, this can lead to confusion. See: - #946 (comment), equal field elements were considered as unequal. - #946 (comment), assert_eq! wasn't meaningful. Signed-off-by: Arvind Mukund <[email protected]>
Signed-off-by: Arvind Mukund <[email protected]>
tarcieri
reviewed
Nov 2, 2023
Signed-off-by: Arvind Mukund <[email protected]>
tarcieri
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using p521, the limbs can be populated differently which when deriving [
Debug] shows up as different values for equal FieldElements, this can lead to confusion.See:
FieldElement::{sqrt, invert}and add basic field tests #946 (comment), equal field elements were considered as unequal.FieldElement::{sqrt, invert}and add basic field tests #946 (comment), assert_eq! wasn't meaningful.