chore: improve build responsiveness OLD #2972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifoosid
previously approved these changes
Mar 19, 2021
vladitasev
changed the title
|
Closed in favor of: #2992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes 2 bugs of the
yarn startcommand:.cssfiles are not usable unlessyarn startis killed and re-run. The reason is a knownpostcssbug in--watchmode: newly created files are not detected, only existing files are re-compiled (--watch mode doesn't pick up new files postcss/postcss-cli#161).messagebundle.propertiesare not automatically available ini18n-defaults.jsand if you try to use them - the bundle breaks. This is due to the fact that there is no watch mode fori18n.Changes:
chokidarfor watching thethemes/directory instead ofpostcss --watch. Note: this is only necessary for component css files. Themes css files are fine withpostcss --watch, because new ones are never created.watchtask fori18ntoo: it only needs to watch themessagebundle.propertiesfile and regenerate the defaults file (not the.jsons).After the change it's possible to create a new component with all needed files and resources without restarting
yarn start.