libselinux: Add CPPFLAGS to Makefile #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vapier
reviewed
Aug 30, 2022
|
This PR was somehow missed in past. Is it still relevant? In order to get the patch reviewed and accepted, it's necessary to send it to [email protected] mailing list. The best way is to use git send-email command, e.g.: git send-email --from='Your Name [email protected]' --to=[email protected] --smtp-server=my.smtp.server --confirm=auto -1 Please also note that the project moved the development to main branch - https://lore.kernel.org/selinux/CAHC9VhTo0LnHwfnF1kfNcosUDdB=MtBQePemR+ju81_GFSuGiA@mail.gmail.com/T/#u |
Add CPPFLAGS to Makefile to allow users change the flags of preprocessor. We offen use CFLAGS for compiler flags and use CPPFLAGS for preprocessor. Signed-off-by: Chung-Sheng Wu <[email protected]>
|
Sent a mail for the patch. Will close this once it get reviewed. |
vapier
reviewed
Jun 8, 2023
|
|
||
| $(SWIGRUBYSO): $(SWIGRUBYLOBJ) | ||
| $(CC) $(CFLAGS) $(LDFLAGS) -L. -shared -o $@ $^ -lselinux $(RUBYLIBS) | ||
| $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) -L. -shared -o $@ $^ -lselinux $(RUBYLIBS) |
There was a problem hiding this comment.
don't use $(CPPFLAGS) when linking
|
Updated. But created a new PR #398 to merge to main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CPPFLAGS to Makefile to allow users change the flags of
preprocessor.
We offen use CFLAGS for compiler flags and use CPPFLAGS for
preprocessor.
Signed-off-by: Chung-Sheng Wu [email protected]