-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wavefield injection based on wavefield discontinuity #1706
Conversation
…_TYPE==1 .and. .not. backward_simulation)
!! add back displacement discontinuity for inner elements of | ||
!! the discontinuity interface | ||
!! note that this is called in adjoint simulation | ||
if (IS_WAVEFIELD_DISCONTINUITY .and. & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this breaks the OpenMP version.
please add the IS_WAVEFIELD_DISCONTINUITY
variable to the $OMP SHARED(..)
section to fix it.
DATA/CMTSOLUTION
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a bit unfortunate to delete and then re-insert this file. git won't be able to track changes in this file like this.
if still possible, can you try to revert back to the initial file? note that the files in folder SPECFEM3D/DATA/ are all symbolic links to the files in the main "default" example EXAMPLES/applications/homogeneous_halfspace/DATA/
.
DATA/Par_file
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with this file
DATA/STATIONS
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this file.
i'll leave the PR open for now. please try to fix the above mentioned issues by adding the necessary commits to your devel version. |
Hi Daniel, thanks for the comments! I have restored the symbolic links in the DATA/ directory, and I have added the IS_WAVEFIELD_DISCONTINUITY flag to the OMP directive. I hope it can pass the tests now. |
great, looks all good - thanks for the quick fix! |
Thanks for helping me with my first pull request! |
An implementation of wavefield injection based on wavefield discontinuity which naturally accommodates PML/Stacey. An small example for coupling with FK is provided in EXAMPLES/applications/wavefield_discontinuity. More examples to be provided in future commits. Currently only forward simulation is implemented, adjoint simulation and kernel calculation will come soon. HDF5 and GPU supports will be implemented in the near future.