802 player time api #814
Open
802 player time api #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
1 task
Code Coverage
Files
|
MGaetan89
approved these changes
Nov 28, 2024
| /** | ||
| * Local time formatter that format [LocalTime] to HH:mm:ss. | ||
| */ | ||
| val localTimeFormatter by lazy { |
There was a problem hiding this comment.
Update CountdownView to use this formatter, since it defined its own with the same configuration?
| @@ -306,9 +312,15 @@ private fun PlayerTimeRow( | |||
| var compactMode by remember { | |||
| mutableStateOf(true) | |||
| } | |||
| val isLive by player.isCurrentMediaItemLiveAsState() | |||
| val positionTime = if (isLive) player.getUnixTimeMs(positionMs) else C.TIME_UNSET | |||
There was a problem hiding this comment.
Shouldn't we pass a Window to getUnixTimeMs()?
Comment on lines
+38
to
+40
| LaunchedEffect(player) { | ||
| player.play() | ||
| } |
There was a problem hiding this comment.
Why not use a LifecycleEffect here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to provide API and helper to better handle timestamp based stream. Streams may have timestamps information inside their playlist. Media3 is able to extract those informations inside the
Timeline.Window.Pillarbox provide helper to manipulate time based on that information. Those API work only and only if there are timestamp information. Pillarbox doesn't make magic with live streams that haven't timestamp inside the stream.
Changes made
Player. getUnixTimeMs.Player. seekToUnixTimeMs.Checklist