Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(npm): update to video.js version 8.13.0 #250

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amtins
Copy link
Member

@amtins amtins commented Apr 29, 2024

Description

This update to video.js v8.13.0 introduces spatial navigation functionality.

// Enables the spatial navigation
const player = videojs('my-player', {
  spatialNavigation: {
    enabled: true,
    horizontalSeek: true
  }
});

// Starts the spatial navigation
player.spatialNavigation.start();

Changes made

  • update package.json and package-lock.json

This update to video.js [v8.13.0](https://github.com/videojs/video.js/releases/tag/v8.13.0)
introduces spatial navigation functionality.

```javascript
// Enables the spatial navigation
const player = videojs('my-player', {
  spatialNavigation: {
    enabled: true,
    horizontalSeek: true
  }
});

// Starts the spatial navigation
player.spatialNavigation.start();
```

- update package.json and package-lock.json
Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://SRGSSR.github.io/pillarbox-web/pr-preview/pr-250/
on branch gh-pages at 2024-04-29 16:15 UTC

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 98.72% 617/625
🟢 Branches 95.74% 292/305
🟢 Functions 99.43% 173/174
🟢 Lines 99.15% 581/586

Test suite run success

199 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 21e4314

Copy link
Contributor

@jboix jboix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amtins amtins marked this pull request as draft May 1, 2024 07:52
@MGaetan89 MGaetan89 linked an issue May 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

Update video.js dependency
2 participants