Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pillarbox-monitoring): remove severity property from error event #278

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

amtins
Copy link
Member

@amtins amtins commented Oct 21, 2024

Description

Resolves #277 by removing the severity property following the update of the
monitoring specification.

Copy link

github-actions bot commented Oct 21, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-22 08:42 UTC

Copy link

github-actions bot commented Oct 21, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 98.1% 826/842
🟢 Branches 92.96% 383/412
🟢 Functions 98.67% 223/226
🟢 Lines 98.49% 783/795

Test suite run success

247 tests passing in 10 suites.

Report generated by 🧪jest coverage report action from 0f47d02

Resolves #277 by removing the severity property following the update of the
monitoring specification.
@amtins amtins force-pushed the fix/remove-severity-from-player-error branch from 3abb5d2 to 0f47d02 Compare October 21, 2024 14:32
@amtins amtins requested a review from jboix October 21, 2024 14:34
Copy link
Contributor

@jboix jboix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amtins amtins merged commit 614ed7f into main Oct 22, 2024
5 checks passed
@amtins amtins deleted the fix/remove-severity-from-player-error branch October 22, 2024 08:42
Copy link

🎉 This PR is included in version 1.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Remove severity from error payload
2 participants