Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Gradle 8.10 and fix deprecation warnings #45

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Update to Gradle 8.10 and fix deprecation warnings #45

merged 4 commits into from
Aug 30, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Aug 29, 2024 •
edited
Loading

  • Update Gradle from 8.0 to 8.10.
  • Fix a couple of warnings in Gradle scripts.
  • Migrate settings.gradle to Kotlin.
  • Make the code_quality.yml workflow run on the main branch.

@MGaetan89 MGaetan89 self-assigned this Aug 29, 2024
Loic-Dumas
Loic-Dumas previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@Loic-Dumas Loic-Dumas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me, even if I'm still surprise that gradle-wrapper.jar, gradlewand gradlew.bat scripts are commited. 🤷🏾

Loic-Dumas
Loic-Dumas reviewed Aug 29, 2024
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
@Loic-Dumas Loic-Dumas dismissed their stale review August 29, 2024 22:15

pre-commit issue

@MGaetan89
Copy link
Member Author

Good to me, even if I'm still surprise that gradle-wrapper.jar, gradlewand gradlew.bat scripts are commited. 🤷🏾

These are necessary in order to run any Gradle commands. They'll download the full Gradle distribution, and allow you to run ./gradlew ... commands.
If they are not committed, you have nothing to start working on the project when you clone the repo 🙂

@MGaetan89 MGaetan89 added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit c399f76 Aug 30, 2024
6 checks passed
@MGaetan89 MGaetan89 deleted the update_gradle branch August 30, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

@Loic-Dumas Loic-Dumas Loic-Dumas approved these changes

Assignees

@MGaetan89 MGaetan89

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MGaetan89 @Loic-Dumas @StaehliJ