Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in Java/Kotlin code #46

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Fix warnings in Java/Kotlin code #46

merged 3 commits into from
Aug 30, 2024

Conversation

MGaetan89
Copy link
Member

This PR:

  • Fixes the warnings in Java/Kotlin code throughout the project.
  • Replace some Android/Java APIs in Kotlin files with equivalent Kotlin APIs.

@MGaetan89 MGaetan89 self-assigned this Aug 29, 2024
Base automatically changed from update_gradle to main August 30, 2024 09:34
@MGaetan89 MGaetan89 added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit bf8419c Aug 30, 2024
5 checks passed
@MGaetan89 MGaetan89 deleted the fix_warnings branch August 30, 2024 09:43
@MGaetan89 MGaetan89 mentioned this pull request Aug 30, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 3, 2024
@MGaetan89
Update demo app to display request response (#48)
522bb77 
As discussed in
#46 (comment),
I've updated the demo app to get rid of the `Log` `Coucou` and replaced
it with a simple UI:

| Loading | Success | Error |
|-----|-----|------|
|
![Screenshot_20240830_132703](https://github.com/user-attachments/assets/a82d4d94-15c6-4fa4-b648-0713ec8555ec)
|
![Screenshot_20240830_132716](https://github.com/user-attachments/assets/e192332f-e602-4813-8b75-0ca7b7b36c54)
|
![Screenshot_20240830_132854](https://github.com/user-attachments/assets/a5183f08-02c0-475d-b7e1-e298c74c34a5)
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ left review comments

@defagos defagos defagos left review comments

@Loic-Dumas Loic-Dumas Loic-Dumas approved these changes

Assignees

@MGaetan89 MGaetan89

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MGaetan89 @defagos @Loic-Dumas @StaehliJ