Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to the data module #51

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add tests to the data module #51

wants to merge 3 commits into from

Conversation

MGaetan89
Copy link
Member

Changes made:

  • Switch to using classes from kotlin-test instead of jUnit.
  • Add tests to the classes in the remote package.
  • Move existing serializer tests to the serializer package.

@MGaetan89 MGaetan89 self-assigned this Sep 6, 2024
@MGaetan89
Copy link
Member Author

@Loic-Dumas @StaehliJ should we merge this?
It only adds tests to the data package, and simplify some code. But there is no change in logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loic-Dumas Loic-Dumas Awaiting requested review from Loic-Dumas

@StaehliJ StaehliJ Awaiting requested review from StaehliJ

At least 1 approving review is required to merge this pull request.

Assignees

@MGaetan89 MGaetan89

Labels
None yet
Projects
Pillarbox
Status: 🍿 Code Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MGaetan89