-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sui-theme v9 custom-properties available #2754
Open
andresin87
wants to merge
150
commits into
master
Choose a base branch
from
css-native-utils
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤩 |
|
andresin87
requested review from
sui-bot,
kikoruiz and
andresz1
as code owners
August 20, 2024 07:44
andresin87
changed the title
chore(Root): test
sui-theme v9 custom-properties available
Aug 20, 2024
make tag compatible without theme-v7 deprecated sui-theme module
…e-utils # Conflicts: # package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Css native custom properties
🔍 Show
TASK:
Description, Motivation and Context
This PR is using @s-ui/[email protected] which is a proposal to get ready to use css native custom tokens in brand web-apps and brand themes.
Those theme changes can be inspected in SUI-Components/sui#1804
The main handicap is the usage of SASS color functions and css
rgba
color standard.### Replacing errors
When experiencing any problem related to this, the solution is color-mix CSS native color manipulation syntax. EX:
Important
color-mix Browser Compatibility
can be replaced to
also, for scss native color manipulation functions
can be replaced to
Other utils
color-mix allows to nest its inner values
Types of changes
Screenshots - Animations