Fix shell code

.github/workflows/ci.yml

@@ -21,8 +21,9 @@ jobs:
         uses: DavidAnson/markdownlint-cli2-action@v16
         with:
           globs: '**/*.md'
+      # checking shell code with ShellCheck (https://github.com/koalaman/shellcheck)
       - name: Installs packages
         run: sudo apt install shellcheck
       - name: Checks shell file code
         run:
-          shellcheck scripts/**/*.sh
+          shellcheck -e SC2148 scripts/**/*.sh

scripts/download.sh

@@ -1,4 +1,5 @@
 #!/bin/sh
+# Script to download a specific version of the scripts from GitHub
 
 # Usage:
 #   curl ... | ENV_VAR=... sh -

scripts/index.sh

@@ -1,3 +1,6 @@
+#!/bin/bash
+# File to be sourced to have all shell functions available in the bash terminal
+
 SCRIPT_FOLDER=$(dirname "${BASH_SOURCE[0]}")
 for file in ${SCRIPT_FOLDER}/*/*.sh
 do {

scripts/k3s/cluster-lifecycle.sh

@@ -1,3 +1,4 @@
+#!/bin/sh
 # Collection of functions to manage K3s cluster lifecycle
 
 #######################################

scripts/kubernetes/certificate-management.sh

@@ -1,3 +1,4 @@
+#!/bin/sh
 # Collection of functions to add components to manage certificates in a Kubernetes cluster
 
 #######################################

scripts/kubernetes/cluster-status.sh

@@ -1,3 +1,4 @@
+#!/bin/sh
 # Collection of functions to add query status on a Kubernetes cluster
 
 #######################################
@@ -14,7 +15,7 @@ k8s_wait_fornodesandpods() {
     sleep 5
   done
   while true; do
-    NOT_READY_NODES=$(kubectl get nodes --no-headers 2>/dev/null | grep -v " Ready" | wc -l)
+    NOT_READY_NODES=$(kubectl get nodes --no-headers 2>/dev/null | grep -c " Ready")
     if [ "$NOT_READY_NODES" -eq 0 ]; then
       echo "All nodes are ready."
       break

scripts/rancher/cluster-actions.sh

@@ -1,3 +1,4 @@
+#!/bin/sh
 # Collection of functions to manage clusters from Rancher
 
 #######################################

scripts/rancher/manager-lifecycle.sh

@@ -1,3 +1,4 @@
+#!/bin/sh
 # Collection of functions to manage Rancher lifecycle
 
 #######################################

scripts/rancher/manager-settings.sh

@@ -1,3 +1,4 @@
+#!/bin/sh
 # Collection of functions to update Rancher settings
 
 #######################################

scripts/rancher/user-actions.sh

@@ -1,3 +1,4 @@
+#!/bin/sh
 # Collection of functions to make user actions
 
 #######################################
@@ -77,7 +78,7 @@ rancher_create_apikey() {
     -H "Authorization: Bearer $token" \
     --data-binary '{
       "type": "token",
-      "description": "${description}",
+      "description": "$description",
       "ttl": 0
     }')
   echo "DEBUG API_KEY_RESPONSE=${API_KEY_RESPONSE}"