Feature/Initialize the solution #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hierynomus
reviewed
Sep 2, 2024
| local emailAddress=$2 | ||
|
|
||
| echo "Creating certificate issuers using Let's Encrypt..." | ||
| helm repo add devpro https://devpro.github.io/helm-charts |
There was a problem hiding this comment.
This one we might want to move at some point in time
There was a problem hiding this comment.
Yes! Added a TODO, really need to do this one (as for the container images)
hierynomus
reviewed
Sep 2, 2024
|
|
||
| verify_system() { | ||
| info 'Verify system requirements' | ||
| if [ -x /usr/bin/git ] || type git > /dev/null 2>&1; then |
There was a problem hiding this comment.
Maybe we should also verify jq present as a lot of commands depend on it.
scripts/rancher/manager-lifecycle.sh
Outdated
| --set hostname=${hostname} \ | ||
| --set ingress.extraAnnotations.'cert-manager\.io/cluster-issuer'=${clusterissuer} \ | ||
| --set ingress.tls.source=secret \ | ||
| --set ingress.tls.secretName=rancher-tls |
There was a problem hiding this comment.
For v2.9.1 we need to also pass
--set agentTLSMode="system-store"
|
Latest version of the scripts just validated on Rancher playground track |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Validation: