Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement hybrid sort #593

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: implement hybrid sort #593

wants to merge 1 commit into from

Conversation

Saghen
Copy link
Owner

@Saghen Saghen commented Dec 16, 2024

Closes #570

Implements the hybrid sort strategy from Zed, as mentioned in the issue.

  • score_threshold needs tuning
  • score_offset ends up not being respected when < score_threshold
    • Do we need a different solution for this? nvim-cmp uses a "priority" system, what are the pros and cons here?
  • use_proximity performs poorly inside match in rust. Should we only enable proximity when sort_text == nil?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect LSP suggestion ordering
1 participant