feat: rework download logic with checksums #629
Merged
+417
−226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #459
Closes #68
Adds checksums to the binary and validates it on every startup (takes 1ms, non-blocking). If the checksums don't match, the binary will be re-downloaded. Should also fix a theoretical issue where a failed download would be marked as "locally built"
@scottmckendry If you get the chance, could you test this on windows/mac? I've got a release with checksums up at https://github.com/Saghen/checksum-test