Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework download logic with checksums #629

Merged
merged 2 commits into from
Dec 20, 2024
Merged

feat: rework download logic with checksums #629

merged 2 commits into from
Dec 20, 2024

Conversation

Saghen
Copy link
Owner

@Saghen Saghen commented Dec 17, 2024

Closes #459
Closes #68

Adds checksums to the binary and validates it on every startup (takes 1ms, non-blocking). If the checksums don't match, the binary will be re-downloaded. Should also fix a theoretical issue where a failed download would be marked as "locally built"

@scottmckendry If you get the chance, could you test this on windows/mac? I've got a release with checksums up at https://github.com/Saghen/checksum-test

{
  "saghen/checksum-test",
  version = '*',
  config = function(_, opts)
    require('blink.cmp').setup(opts)
  end
},
{
  'saghen/blink.cmp',
  enabled = false
}

@Saghen Saghen requested a review from scottmckendry December 17, 2024 22:49
@scottmckendry
Copy link
Collaborator

Happy to have a look @Saghen! I should have some time in the next day or so.

Fair warning, I don't have access to a mac and I've since returned the android device I was using for testing to its original owner. I can definitely verify Windows, though 🙂

@Saghen
Copy link
Owner Author

Saghen commented Dec 20, 2024

I ended up setting up windows last night to play a game so I gave it a test while I was there. Thank you as always though!

@Saghen Saghen merged commit 53d22cb into main Dec 20, 2024
2 checks passed
@Saghen Saghen deleted the checksum branch December 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add checksum for binary Neovim crashes after updating
2 participants