fix: Completion item label spacing for non "function-like" items #670
+36
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Issue When dealing with completion items the default `completion.menu.draw.components.label.text(ctx)` function just returns the concatenation of `ctx.label` and `ctx.label_detail` which creates scenarios such as "MyAwesomeModinterface" which is wrongly formatted. ## Solution The solution consists in checking the `ctx.kind` against the internal `types.CompletionItemKind` table and for any kind that is not either `Method`, `Function` or `Constructor` we add a space between the `ctx.label` and `ctx.label_detail`.
bjufre
force-pushed
the
fix/label-spacing
branch
from
2488e33 to
c247173
Compare
|
This seems to be an issue with your LSP because afaict we are meant to concatenate the label and label details together without any spacing |
|
Just double checked, we're not meant to add any spacing: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionItemLabelDetails. Thank you though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When dealing with completion items the default
completion.menu.draw.components.label.text(ctx)function just returns the concatenation ofctx.labelandctx.label_detailwhich creates scenarios such as "MyAwesomeModinterface" which is wrongly formatted.Solution
The solution consists in checking the
ctx.kindagainst the internaltypes.CompletionItemKindtable and for any kind that is not eitherMethod,Function,ConstructororSnippetwe add a space between thectx.labelandctx.label_detail.Examples
Before:
After:
