Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash script for running inference on clips #251

Merged
merged 23 commits into from
Nov 20, 2024
Merged

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Nov 14, 2024

TODO:


Description

What is this PR?

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
To run detection and tracking on a list of videos, using the cluster.

What does this PR do?

  • It adds a bash script for running inference, which incorporates the changes from Add flag to omit timestamp in output directory #253 and previous work.
  • It adds a command to remove the created conda environment to all the bash scripts that create one in the compute node.
    • otherwise if a node is repeatedly visited in an array job, it may get out of memory to store them all.
  • It removes the source ~/.bashrc step from all scripts (it was commented out)
  • It adds a guide for running a detect+track command over a set of videos in the cluster.
    • It follows the evaluation guide and implements some updates to the code.
  • It makes a small edit to the evaluation in the cluster guide.

References

MLflow logging is still pending (PR #254) so we don't make use of it for logging outputs in this script either.

How has this PR been tested?

The bash script has been used to successfully evaluate an array of videos (pointing to the PR branch rather than main).

Does this PR require an update to the documentation?

Yes, a guide has been added.

Checklist:

  • [ n/a ] The code has been tested locally
  • [ n/a ] Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.98%. Comparing base (1cdb184) to head (acb9ca6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   47.98%   47.98%           
=======================================
  Files          24       24           
  Lines        1567     1567           
=======================================
  Hits          752      752           
  Misses        815      815           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sfmig sfmig marked this pull request as ready for review November 19, 2024 15:22
@sfmig sfmig force-pushed the smg/inference-escape-clips branch from e08408e to acb9ca6 Compare November 20, 2024 14:56
@sfmig sfmig merged commit ef33f58 into main Nov 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants