Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT enable publish of tools/model_explorer_circle #14334

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/pub-tools-mec-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,6 @@ jobs:
uses: pypa/gh-action-pypi-publish@release/v1
with:
packages-dir: tools/model_explorer_circle/dist/
skip-existing: true
skip-existing: false
user: __token__
password: ${{ secrets.MEC_PYPI_API }}
6 changes: 2 additions & 4 deletions .github/workflows/run-tools-mec-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ jobs:
test:
strategy:
matrix:
# TODO add more versions
python: ['3.10']
# TODO add more platforms
platform: [ubuntu-latest]
python: ['3.10'] # ['3.10', '3.11', '3.12']
platform: [ubuntu-latest] # [ubuntu-latest, macos-latest, windows-latest]

runs-on: ${{ matrix.platform }}

Expand Down
24 changes: 24 additions & 0 deletions tools/model_explorer_circle/HOWTO.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,27 @@ pytest
flatc -p --gen-onefile --gen-object-api circle_schema.fbs
```
* Note: For `--gen-onefile` option, you need to use the latest version of `flatc`. (tested version = v24.3.25)

## How to local build with nox

Use separate virtual-env:
```
python3 -m venv venv
source venv/bin/activate
```

Install tools:
```
python3 -m pip install --upgrade nox build
```

To run unit tests:
```
python3 -m nox -s tests-3.xx
```
- where `xx` is your python version, for example `10`

To build package:
```
python3 -m build .
```
11 changes: 11 additions & 0 deletions tools/model_explorer_circle/noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,21 @@
import os
import nox

nox.options.sessions = ["lint"]

# Define the minimal nox version required to run
nox.options.needs_version = ">= 2024.3.2"


@nox.session
def lint(session):
# NOTE no need to run lint, as format checker runs with yapf including this project
session.install("yapf==0.40.2")
session.run("yapf", "--verbose", "--in-place", "--recursive", "--exclude",
"src/circle_adapter/circle_schema_generated.py", "noxfile.py", "./src",
"./tests")


@nox.session
def build_and_check_dists(session):
session.install("build", "check-manifest >= 0.42", "twine", "ai-edge-model-explorer",
Expand Down