[luci/pass] Revise FuseInstanceNormPass V6 #14397
Conversation
This will revise FuseInstanceNormPass version_6 to have const_as_beta as zero values. ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
|
@jinevening , is this what you want ? |
| // create 1.0 gamma and 0.0 beta | ||
| auto graph = add_as_terminal->graph(); | ||
| const_as_gamma = make_const_one(graph, 1.0f); | ||
| const_as_gamma->name(add_as_terminal->name() + "/gamma"); | ||
| const_as_beta = make_const_one(graph, 0.0f); | ||
| const_as_beta->name(add_as_terminal->name() + "/beta"); |
There was a problem hiding this comment.
I think these lines are unnecessary. *1 and +0 are Nop.
And, apply functions for version_5 and version_6 have to be updated too. There are no gamma and beta for those patterns, so reshape_gamma_beta function should not be called.
There was a problem hiding this comment.
I think these lines are unnecessary. *1 and +0 are Nop.
I don't understand the meaning. Maybe code example will help.
There was a problem hiding this comment.
And, apply functions for version_5 and version_6 have to be updated too.
I cannot check for ver 5 as of now and do not want to mix for both version in one PR.
| const_as_beta = dynamic_cast<luci::CircleConst *>(sub->x()); | ||
| CHECK_OR_FALSE(const_as_beta); | ||
| CHECK_OR_FALSE(const_as_beta->rank() == 3); | ||
| CHECK_OR_FALSE( | ||
| const_as_beta->dim(0).value() == 1 && const_as_beta->dim(1).value() == input_channel && | ||
| (const_as_beta->dim(2).value() == 1 || const_as_beta->dim(2).value() == input_last_dim)); |
There was a problem hiding this comment.
We may need to check the shape and the value of sub->x() (const_as_zero).
There was a problem hiding this comment.
So we need to check all the values should be 0.0f too ?
|
@jinevening , I think it would be better you to update V6 with your thoughts. |
|
Sorry for late reply. I think we should first determine how to support groupnorm in our backend. If it's done, our task may become clear. |
This will revise FuseInstanceNormPass version_6 to have const_as_beta as zero values.