-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.5][Migration] Tutorial how to migrate Xamarin.Android to Tizen #1545
base: master
Are you sure you want to change the base?
Conversation
checkout the webpage https://docs1.stg.tizen.org/staging/1545 |
Check Broken Link: |
🔑 [Keyword] docs/application/dotnet/guides/index.md
Need help? YAML meta tag guide |
🔑 [Keyword] docs/application/dotnet/guides/migration/migrate-xaml-android.md
Need help? YAML meta tag guide |
🔑 [Keyword] docs/application/dotnet/guides/migration/migrate-xaml-forms.md
Need help? YAML meta tag guide |
🔑 [Keyword] docs/application/dotnet/guides/migration/overview.md
Need help? YAML meta tag guide |
@@ -0,0 +1,7 @@ | |||
# Migrate Xamarin.Android App to Xamarin.Tizen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any content in this page, @patrykka could you please check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrykka kindly check this particular file
ea3a16a
to
610a770
Compare
checkout the webpage https://docs1.stg.tizen.org/staging/1545 |
Check Broken Link: |
🔑 [Keyword] docs/application/dotnet/guides/migration/migrate-xaml-forms.md
Need help? YAML meta tag guide |
checkout the webpage https://docs1.stg.tizen.org/staging/1545 |
Check Broken Link: |
🔑 [Keyword] docs/application/dotnet/guides/migration/migrate-xaml-forms.md
Need help? YAML meta tag guide |
<div class="col col-md-3"> | ||
<div class="card card-infra card-list h-100"> | ||
<div class="card-body"> | ||
<p class="h3 card-title">Maigration to Xamarin.Tizen</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p class="h3 card-title">Maigration to Xamarin.Tizen</p> | |
<p class="h3 card-title">Migration to Xamarin.Tizen</p> |
@patrykka, could you please change the branch to master? |
checkout the webpage https://docs1.stg.tizen.org/staging/1545 |
Check Broken Link: |
🔑 [Keyword] docs/application/dotnet/guides/index.md
Need help? YAML meta tag guide |
@patrykka, this comment needs to be addressed could you please check. Also, the branch needs to be changed to master. |
checkout the webpage https://docs1.stg.tizen.org/staging/1545 |
Check Broken Link: |
🔑 [Keyword] docs/application/dotnet/guides/index.md
Need help? YAML meta tag guide |
@@ -0,0 +1,7 @@ | |||
# Migrate Xamarin.Android App to Xamarin.Tizen | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file still does not have information, and so cannot proceed further with this PR review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrykka, is this file part of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't see information included in this topic. Please check and add the required information.
@patrykka, gentle reminder to fix the comments. |
checkout the webpage https://docs1.stg.tizen.org/staging/1545 |
Check Broken Link: |
🔑 [Keyword] docs/application/dotnet/guides/index.md
Need help? YAML meta tag guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrykka, I have added my review comments. Kindly check and incorporate the changes.
|
||
There is no need to rewrite your Xamarin.Forms and Xamarin.Andorid apps to run them on Tizen Platform. | ||
|
||
Xamarin.Forms App you can load directly to VS and run on your device, while Xamarin.Android specific Apps needs some code changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Xamarin.Forms App you can load directly to VS and run on your device, while Xamarin.Android specific Apps needs some code changes. | |
Xamarin.Forms app you can load directly to VS and run on your device, while Xamarin.Android specific apps needs some code changes: |
|
||
Xamarin.Forms App you can load directly to VS and run on your device, while Xamarin.Android specific Apps needs some code changes. | ||
|
||
- [Migration Xamarin.Forms](migrate-xaml-forms.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [Migration Xamarin.Forms](migrate-xaml-forms.md) | |
- [Migrate Xamarin.Forms](migrate-xaml-forms.md) |
<div class="col col-md-3"> | ||
<div class="card card-infra card-list h-100"> | ||
<div class="card-body"> | ||
<p class="h3 card-title">Maigration to Xamarin.Tizen</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p class="h3 card-title">Maigration to Xamarin.Tizen</p> | |
<p class="h3 card-title">Migration to Xamarin.Tizen</p> |
@@ -0,0 +1,7 @@ | |||
# Migrate Xamarin.Android App to Xamarin.Tizen | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't see information included in this topic. Please check and add the required information.
2. Update namespaces and declared assemblies | ||
3. Convert elements | ||
3. Build and fix any issues | ||
4. Run the converted app and verify that is functions correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4. Run the converted app and verify that is functions correctly. | |
5. Run the converted app and verify that it functions correctly. |
|
||
| Old namespace and assembly | New namespace and assembly | | ||
| ------------------------------------ | ---------------------------------------- | | ||
| xmlns="http://zamarin.com/schemas/2014/forms | xmlns="http://tizen.org/Tizen.NUI/2018/XAML" | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link in the new namespace column is broken. Please check and fix the issue.
| xmlns="http://zamarin.com/schemas/2014/forms | xmlns="http://tizen.org/Tizen.NUI/2018/XAML" | | ||
| | xmlns:base="clr-namespace:Tizen.NUI.BaseComponets;assembly=Tizen.NUI" | | ||
| | xmlns:comp="clr-namespace:Tizen.NUI.Componets;assembly=Tizen.NUI.Components" | | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | xmlns:x="https://schemas.microsoft.com/winfx/2009/xaml" | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check these links, since the target pages are not opening.
|
||
### Convert elements | ||
|
||
Basing on sample app source code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we missing text in this sentence?
Basing on sample app source code | |
Based on sample app source code..........??? |
|
||
| Xamarin.Forms | Xmarin.Tizen | | ||
| ------------- | ------------ | | ||
|[XAML Forms Page](FormsXamlPage.xaml)|[XAML Tizen Page](TizenXamlPage.xaml) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hyperlinks are broken. Please check and fix the issue.
|
||
#### XAML Source | ||
|
||
Below table shows UI elements form Xamarin.Forms and their replacement in NUI Xaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if following suggestion looks fine?
Below table shows UI elements form Xamarin.Forms and their replacement in NUI Xaml | |
The following table shows UI elements from Xamarin.Forms and their replacement in NUI Xaml: |
@patrykka , Just a reminder for incorporating the requested changes. |
@patrykka , A second reminder for incorporating the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrykka greetings. Hope you are doing well. This PR has been inactive for a while. Would you please make the previously requested changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrykka Hope you are doing well. This is another gentle reminder to incorporate the previously suggested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @patrykka. Hope you are doing okay! This PR has been inactive for a very long time. Please incorporate the previously requested changes at your earliest convenience. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @patrykka! It's been a while. Hope you are doing okay. I wanted to give a gentle reminder to incorporate the previously suggested changes. Please incorporate those, thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @patrykka! Hope you are doing well!
It's been some time since there was any activity with this PR. I wanted to give a gentle reminder to incorporate the previously suggested changes. Please incorporate those changes whenever you can. Thank you!
Change Description
Describe your changes here.
For instance,
Bugs Fixed
Provide links to bugs here
For instance,
API Changes
In case of ACR, put the link of ACR
For instance,