Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertion to prevent max_id overflowing #1435

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Add assertion to prevent max_id overflowing #1435

merged 8 commits into from
Nov 27, 2024

Commits on Nov 13, 2024

  1. Make assertion to not overflow

    @Ukendio
    Ukendio authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fc8171c View commit details
    Browse the repository at this point in the history

  2. Use UINT32_MAX

    @Ukendio
    Ukendio authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f5d1ab1 View commit details
    Browse the repository at this point in the history

  3. Use the id directly

    @Ukendio
    Ukendio authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2b3ffc7 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Merge branch 'SanderMertens:master' into patch-1

    @Ukendio
    Ukendio authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    e491f96 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @Ukendio
    Ukendio committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ca8c22e View commit details
    Browse the repository at this point in the history

  3. Id should be able to be exactly UINT32_MAX

    @Ukendio
    Ukendio committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    aff0f44 View commit details
    Browse the repository at this point in the history

  4. Test with set_entity_range instead

    @Ukendio
    Ukendio committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    75fc1f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Add test that triggers assert in bulk ids

    @Ukendio
    Ukendio committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1d3678e View commit details
    Browse the repository at this point in the history