Better handling for providers in concurrent actions #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobCallahan
commented
Sep 18, 2024
This change simplifies the way we add provider validators to dynaconf. Instead of attempting to add new validators when a class instance is created, we instead add it when the class itself is created. This means that it will happen once immediately when broker is loaded.
JacobCallahan
force-pushed
the
alt_loading
branch
from
2b62bc7
to
a1053c2
Compare
JacobCallahan
changed the title
This change rewrites the way broker actions handle concurrency. Previously, this was offloaded in a manner that was wasteful in the way it handled pre-action setup. Now, we don't go concurrent until we're ready to perform the action we want.
JacobCallahan
force-pushed
the
alt_loading
branch
from
a859021
to
eeb6f94
Compare
ogajduse
approved these changes
Sep 19, 2024
tpapaioa
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- First Commit ---
This change simplifies the way we add provider validators to dynaconf. Instead of attempting to add new validators when a class instance is created, we instead add it when the class itself is created. This means that it will happen once immediately when broker is loaded.
--- Second Commit ---
This change rewrites the way broker actions handle concurrency.
Previously, this was offloaded in a manner that was wasteful in the way
it handled pre-action setup.
Now, we don't go concurrent until we're ready to perform the action we
want.