No blank cvpage test #12775
No blank cvpage test #12775
Conversation
|
I reviewed the airgun part and I'm ready to review this, may I just suggest making this in to exactly two commits, one with the file move and renaming new to old, and the other with new content? So the reviewers don't have a hard time identifying what is what. |
|
There's an older PR that should get merged soon, that has the move and rename as the majority of the content. |
|
@lhellebr This should be much more reasonable to review now, the PR that this required is now merged :) |
sambible
added
6.14.z
sambible
force-pushed
the
no-blank-cvpage
branch
from
ded54a6 to
19bf6fe
Compare
sambible
force-pushed
the
no-blank-cvpage
branch
from
714dfd5 to
6f4a14a
Compare
tests/foreman/ui/test_contentview.py
Outdated
| ).create() | ||
| with target_sat.ui_session(user=user.login, password=user_password) as session: | ||
| session.user.update(user.login, {'user.language': 'Français'}) | ||
| assert session.contentview_new.check_if_blank_in_french() |
There was a problem hiding this comment.
Looking at check_if_blank_in_french, I don't think that asserts anything.
Can you add a different assertion to check?
There was a problem hiding this comment.
It's simply asserting that the table exists - the bug in this case was that in different languages, i.e. french, the page wouldn't display at all. So in this case, simply asserting that the table exists is sufficient.
|
trigger: test-robottelo |
sambible
force-pushed
the
no-blank-cvpage
branch
from
01b7df1 to
2e0f977
Compare
|
PRT passed pre merge stuff, going to rebase this one locally. |
* Renaming old CVUI tests to remove them from pipeline, and add first new CVUI tests * Rename files, remove assignee, and remove search test * Readd casecomponent marker to old cv tests * Fix test docstring issues * Add test for blank page in french language * Update test docstring * Update entity reference * Create CV before UI session begins * Update test steps
Test for a strange BZ we received, where certain characters in other languages ( Like French, in this example ) broke the CV page, and caused it to appear blank.
This test simply changes the language for a user to French, and navigates to the CV page and asserts it's not blank.
This should not be used as an example of increasing or beginning automation efforts around translations, as there are other teams in red hat that do this. This is is simply automating something that got through as a BZ, and is here mostly as a guard against regressions of that particular BZ.
Requires sister airgun PR: SatelliteQE/airgun#991