Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request timeout option to everything #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mittagessen
Copy link

Right now there are no timeouts on any of the API requests. I've added the timeout option on the global state which sets the requests package timeout argument on all the calls.

I can add a short documentation sentence about it to the readme, perhaps in the "On queries and performance" section?

Regarding tests, I'm unsure on how to add sensible ones.

@teleyinex
Copy link
Member

Hi,

This is nice :D Quick thing, before merging anything we need you to sign our Contributor Agreement

Now, back to your code: I would say, that for tests we have to mock the request, and make it timeout, so the requests package uses it. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants