Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adapt to UIGF 4.0 #1095

Open
wants to merge 4 commits into
base: dev/features
Choose a base branch
from
Open

Conversation

Eric-Joker
Copy link
Contributor

@Eric-Joker Eric-Joker commented Sep 17, 2024

  • 保留了旧标准的导出,没做冗余键值处理;导入时自动区分新旧标准。
  • 有些对于starward必要的属性在标准中并不是必填项,做了个自动补充
  • 同一款游戏多uid同时导入

UIGF v4将三款游戏的记录合并为一个标准,理论上允许同时导入。但Starward的UI是每个游戏单独的界面,如果一次导入多款游戏的数据可能有违背交互逻辑,所以没做相关功能。

记得去 https://github.com/UIGF-org/UIGF-org.github.io/pulls 认证()

close #1073 , close #1078 , close #1080
嗯,不是主分支,不会自动关闭议题

@Eric-Joker Eric-Joker force-pushed the uigf4 branch 3 times, most recently from 28553de to b64841d Compare September 19, 2024 05:47
@studiobutter
Copy link

studiobutter commented Dec 11, 2024

[EN]
The Export Function works as intended for all games, although certain area still need to be fix for the import function to work.

  • Genshin Impact: Import and Export is working as intended
  • Honkai: Star Rail: Export is working as intended but Import function have some issues
    • SRGF JSON files cannot be imported
    • UIGF JSON files from other apps like Hoyo Buddy cannot be imported
  • Zenless Zone Zero: Export is working as intended but Import only work for importing logs exported from Starward and is incompatible with importing UIGF v4.0 Logs from other apps like Hoyo Buddy

[CN - Microsoft 翻译]
导出功能适用于所有游戏,但某些区域仍需要修复才能使导入功能正常工作。

  • 原神:进出口按预期工作
  • 崩坏:星穹铁道:导出按预期工作,但导入功能存在一些问题
    • 无法导入 SRGF JSON 文件
    • 无法导入来自 Hoyo Buddy 等其他应用程序的 UIGF JSON 文件
  • 绝区零:导出按预期工作,但导入仅适用于导入从 Starward 导出的日志,并且与从 Hoyo Buddy 等其他应用程序导入 UIGF v4.0 日志不兼容

Sample files:

Note: UIDs for these files have been replaced with dummy ones. Hopefully these files will help improving this feature
注意:这些文件的 UID 已替换为虚拟 UID。希望这些文件将有助于改进此功能

@Eric-Joker
Copy link
Contributor Author

tks,I'll be doing maintenance in the next few days.

@Eric-Joker
Copy link
Contributor Author

Eric-Joker commented Dec 13, 2024

  • SRGF JSON files cannot be imported

fixed

UIGF JSON files from other apps like Hoyo Buddy cannot be imported

This is caused by the data source not outputting the required item in the standard, but the item is not considered important, I'll do an auto-completion.

but Import only work for importing logs exported from Starward

This is because the data source is missing data that is not necessary for the standard but is necessary for Starward, and the fetching of ZZZ item metadata is still not implemented within Starward, making autocompletion impossible. Since Starward suspend accepting PR I do not intend to implement the ability to fetch item metadata.

@Eric-Joker Eric-Joker force-pushed the uigf4 branch 2 times, most recently from 9906ca2 to 8ab11e5 Compare December 15, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants