feat(k6): add scenario with multiple stages ramping up/down RPS #6031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added scenario allows one to configure an arbitrary number of stages, with each consisting of a linear ramp-up/down to the desired rate and a hold/plateau time. Within each stage, the duration for which the inference RPS is held constant is configured via one element in the `CONSTANT_RATE_DURATIONS_SECONDS` environment variable (a vector of comma separated values), with the ramp-up/ down duration preceding it being 1/3rd of the hold time.
sakoush
approved these changes
Nov 8, 2024
| doInfer(modelName, modelNameWithVersion, config, false, idx) | ||
| } else { | ||
| throw new Error('Both REST and GRPC protocols are disabled!') | ||
| } |
There was a problem hiding this comment.
should we add the option to trigger applyModelReplicaChange as well in these tests?
There was a problem hiding this comment.
yes, I'll add that. Until now the data-plane tests and the control-plane tests were quite well separated, now I believe we should always have the option of some control-plane changes during the data-plane load test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added scenario allows one to configure an arbitrary number of stages,
with each consisting of a linear ramp-up/down to the desired rate and a
hold/plateau time.
Within each stage, the duration for which the inference RPS is held constant
is configured via one element in the
CONSTANT_RATE_DURATIONS_SECONDSenvironment variable (a vector of comma separated values), with the ramp-up/
down duration preceding it being 1/3rd of the hold time.
Special notes for your reviewer: