-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: console errors in tests #603
Conversation
+ TypeScript error fixes
Codecov Report
@@ Coverage Diff @@
## develop #603 +/- ##
===========================================
+ Coverage 91.56% 91.58% +0.02%
===========================================
Files 198 198
Lines 5403 5404 +1
Branches 1377 1376 -1
===========================================
+ Hits 4947 4949 +2
+ Misses 456 455 -1
Continue to review full report at Codecov.
|
fieldsToDisplay is a required field. It makes no sense to show null if it is undefined.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵️♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
There were some annoying console errors when tests run. Also fixed typescript errors in tests.
There are still 2 more console warning about components not compatible with React 16.9.
react-quill
andreact-autosuggest
react-autosuggest warning moroshko/react-autosuggest#681 (comment) is going to go away once released.
react-quill is waiting for zenoamaro/react-quill#549. It might not get merged anytime soon.