Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: console errors in tests #603

Merged
merged 2 commits into from
Mar 20, 2020
Merged

fix: console errors in tests #603

merged 2 commits into from
Mar 20, 2020

Conversation

zoltanbedi
Copy link
Contributor

There were some annoying console errors when tests run. Also fixed typescript errors in tests.

There are still 2 more console warning about components not compatible with React 16.9.
react-quill and react-autosuggest
react-autosuggest warning moroshko/react-autosuggest#681 (comment) is going to go away once released.
react-quill is waiting for zenoamaro/react-quill#549. It might not get merged anytime soon.

+ TypeScript error fixes
@zoltanbedi zoltanbedi self-assigned this Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #603 into develop will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #603      +/-   ##
===========================================
+ Coverage    91.56%   91.58%   +0.02%     
===========================================
  Files          198      198              
  Lines         5403     5404       +1     
  Branches      1377     1376       -1     
===========================================
+ Hits          4947     4949       +2     
+ Misses         456      455       -1     
Impacted Files Coverage Δ
.../sn-controls-react/src/fieldcontrols/TagsInput.tsx 98.13% <100.00%> (+0.93%) ⬆️
...eact/src/ContentList/CellTemplates/ActionsCell.tsx 100.00% <100.00%> (ø)
...s-react/src/ContentList/CellTemplates/DateCell.tsx 100.00% <100.00%> (ø)
...ct/src/ContentList/CellTemplates/ReferenceCell.tsx 100.00% <100.00%> (ø)
...ist-controls-react/src/ContentList/ContentList.tsx 97.75% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e75c945...a431b9d. Read the comment docs.

fieldsToDisplay is a required field.
It makes no sense to show null if it is undefined.
@sensenet
Copy link

sensenet bot commented Mar 19, 2020

Site name Url Last deploy
sn-app-dev https://5e73da51c2458bc035992037--sn-app-dev.netlify.com Thu Mar 19 2020 - 20:47:15 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://5e73da41842a499de4c0c26c--sn-react-component-docs-dev.netlify.com Thu Mar 19 2020 - 20:46:58 GMT+0000 (Coordinated Universal Time)

Copy link
Contributor

@herflis herflis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵️‍♂️

Copy link
Contributor

@enikonemeth enikonemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@zoltanbedi zoltanbedi merged commit c36646f into develop Mar 20, 2020
@zoltanbedi zoltanbedi deleted the fix/test-console-errors branch March 20, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants