Fix single-arg Coordinate() constructor
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Coordinate()` has a single-arg (not counting the `self` arg)
constructor overload that is unusable because the overloaded constructor
requires two args.
from stgpytools import Coordinate
Coordinate((0, 0))
# TypeError: Coordinate.__init__() missing 1 required positional argument: 'y'
This is caught by mypy but the error was being `type: ignore`'d. This
patch fixes the issue by making the `y` arg optional in the overloaded
constructor's signature (but it's still required overall).
This was originally discovered via vs-masktool's `BoundingBox`:
from vsmasktools import BoundingBox
BoundingBox((0, 0), (100, 100))
# File "vs-masktools/vsmasktools/abstract.py", line 36, in __init__
# self.pos, self.size, self.invert = Position(pos), Size(size), invert
# ^^^^^^^^^^^^^
# TypeError: Coordinate.__init__() missing 1 required positional argument: 'y'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coordinate()has a single-arg (not counting theselfarg) constructor overload that is unusable because the overloaded constructor requires two args.This is caught by mypy but the error was being
type: ignore'd. This patch fixes the issue by making theyarg optional in the overloaded constructor's signature (but it's still required overall).This was originally discovered via vs-masktool's
BoundingBox: