Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add postal and metro code to oxygen headers #2429

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Add postal and metro code to oxygen headers #2429

merged 1 commit into from
Aug 15, 2024

Conversation

jgodson
Copy link
Contributor

@jgodson jgodson commented Aug 13, 2024 •
edited
Loading

WHY are these changes introduced?

These are now supported, so adding hardcoded values for minioxygen

WHAT is this pull request doing?

Adds these headers to mini-oxygen so they will be available in the buyer headers

HOW to test your changes?

  • These should be available in the Hydrogen worker when running with miniflare on this branch

Post-merge steps

  • Documentation updates

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@shopify Shopify
Copy link
Contributor

shopify bot commented Aug 13, 2024 •
edited
Loading

Oxygen deployed a preview of your add-postal-and-metro-code-oxygen-headers branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment August 13, 202410:12 PM

Learn more about Hydrogen's GitHub integration.

@jgodson jgodson requested a review from frandiox August 14, 2024 20:53
frandiox
frandiox approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge when this is available in Oxygen?

@jgodson
Copy link
Contributor Author

jgodson commented Aug 15, 2024

Let's merge when this is available in Oxygen?

It is available now!

@frandiox frandiox merged commit 9dd4c61 into main Aug 15, 2024
13 checks passed
@frandiox frandiox deleted the add-postal-and-metro-code-oxygen-headers branch August 15, 2024 16:35
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgodson @frandiox