Use CURL imported target instead of variables set by find_package
#412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch I made locally to fixes #411
Instead of relying on the variables set by
find_package
this uses an imported target from the curl cmake files to ensure libcurl is available. I'm not fully sure whyfind_package
wasn't getting the full set of curl libraries required, maybe it was due to multiple installations of libcurl or if it was built locally? But it seems like using an imported target is generally preferred in newer cmakeThis did require bumping the min version of cmake supported since the imported target was only added in 3.12. I'm not sure if thats an issue or not, an alternative solution would be to use find_package and explicitly request
libcurl
as a required component