Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid to consume too much memory while building #34

Merged
merged 4 commits into from
May 21, 2024

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented May 17, 2024

On Windows with cl compiler, building cppad.cpp can consume up to 6 Go of memory.

This prevent conda-forge CI to build this package with the last eigenpy version.

This patch use explicit template instantiation to build all eigenpy::exposeType call in a different translation unit.

To test if this patch is working, I have applied it manually in the following pycppad-feedstock PR.

@jorisv jorisv requested a review from jcarpent May 17, 2024 21:15
@jorisv jorisv self-assigned this May 17, 2024
@jorisv jorisv force-pushed the topic/minimize_build_memory branch 2 times, most recently from 49a78b6 to b4e2387 Compare May 19, 2024 20:29
@jorisv
Copy link
Contributor Author

jorisv commented May 19, 2024

@jcarpent All fixed, but I didn't test cppadcodegen with clang-cl. Did you want this test back ?

@jorisv jorisv force-pushed the topic/minimize_build_memory branch 2 times, most recently from 79db562 to 52a6f00 Compare May 21, 2024 18:23
@jorisv jorisv force-pushed the topic/minimize_build_memory branch from 52a6f00 to e666894 Compare May 21, 2024 18:30
@jorisv jorisv merged commit ff01191 into Simple-Robotics:devel May 21, 2024
5 checks passed
@jorisv jorisv deleted the topic/minimize_build_memory branch May 21, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants