-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration for custom events #5724
base: dev/feature
Are you sure you want to change the base?
Conversation
(cherry picked from commit 07e1700)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool pr!
I am a little worried about users adding async events and then having issues using syntax inside those events (like the chat event in 2.7 betas), but I suppose it's on their heads if they add an async event. Perhaps a warning about that in the file would be good.
edit: Apparently i forgot to save this comment:
You can leave the name blank, which doesn't seem to cause issues but should not be allowed imo:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bd134d0
to
3f08853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation seems fine, but I do find myself wondering whether this is something we should add. We may be better off pointing these users to skript-reflect (which we now officially maintain) if they're looking for features like this. Up for debate.
Description
Adds a configuration for registering simple events, ported from Skellett.
Target Minecraft Versions: any
Requirements: none
Related Issues: #121 (non-closing)