Database File Limit #7047
Merged
Database File Limit #7047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note, to optimally fix the |
TheLimeGlass
requested changes
Sep 7, 2024
There was a problem hiding this comment.
Looking good.
Dev note: The breaking change is because the field behavior is being changed from type to configuration name, thus the field should be private to avoid anyone extending VariableStorage to be using old behavior.
The current VariableStorage API is very recent, and this change is minimal.
TheLimeGlass
requested changes
Sep 7, 2024
TheLimeGlass
added
enhancement
Added, Javadoc note for getUserConfigurationName() Changed, database(Name|Type) fields to private Changed, all usages of 'databaseName' to 'getUserConfigurationName()' Changed, 'registeredFiles' to Set Changed, 'name' var
|
Question, should we also restrict the usage of same database names? |
TheLimeGlass
approved these changes
Sep 19, 2024
sovdeeth
requested changes
Oct 12, 2024
sovdeeth
reviewed
Oct 12, 2024
sovdeeth
approved these changes
Oct 12, 2024
Efnilite
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to restrict the usage of a file to only one database. Precautionary measure
databaseNamefield and adds adatabaseTypefieldTarget Minecraft Versions: any
Requirements: none
Related Issues: #6858