Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the REMOVE changer of variables #7163

Merged
merged 6 commits into from
Dec 15, 2024
Merged

Fix the REMOVE changer of variables #7163

merged 6 commits into from
Dec 15, 2024
+18 −35

Conversation

UnderscoreTud
Copy link
Member

@UnderscoreTud UnderscoreTud commented Oct 24, 2024 •
edited by Moderocky
Loading

Description

Currently, removing elements from a list will only remove the first instance found in that list.

set {_list::*} to 1, 2, 1, 3
remove 1 and 1 from {_list::*}
broadcast {_list::*} # 2, 1, 3

This PR aims to fix that issue

Target Minecraft Versions: any
Requirements: none
Related Issues: #7162

@UnderscoreTud UnderscoreTud added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Oct 24, 2024
@Efnilite

This comment has been minimized.

Sign in to view
Asleeepp
Asleeepp approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@Asleeepp Asleeepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heres my very important approval

@UnderscoreTud UnderscoreTud added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Oct 28, 2024
@UnderscoreTud UnderscoreTud added the 2.10 Targeting a 2.10.X version release label Nov 9, 2024
@sovdeeth sovdeeth merged commit aa71764 into dev/patch Dec 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Asleeepp Asleeepp Asleeepp approved these changes

@Fusezion Fusezion Fusezion approved these changes

@Efnilite Efnilite Efnilite approved these changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
2.10 Targeting a 2.10.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@UnderscoreTud @Efnilite @sovdeeth @Moderocky @Fusezion @Asleeepp