-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Equippable components #7194
base: dev/feature
Are you sure you want to change the base?
Equippable components #7194
Conversation
…leComponents # Conflicts: # src/main/java/ch/njol/skript/Skript.java # src/main/resources/lang/default.lang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Can you explain the reasoning behind making the equippable component a new type? Why not just have all the syntaxes act on items, like you already have them doing? |
I believe having this new type will be beneficial for storing template equippable components. I personally feel it to be more intuitive |
…leComponents # Conflicts: # src/main/java/ch/njol/skript/util/slot/EquipmentSlot.java
Description
This PR aims to add support for the upcoming Equippable Components to Skript.
This will be marked as draft due to Equippable Components being ApiStatus.Experimental at this time.
Open to any syntax changes.
Target Minecraft Versions: any
Requirements: none
Related Issues: none