Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equippable components #7194

Open
wants to merge 11 commits into
base: dev/feature
Choose a base branch
from

Conversation

TheAbsolutionism
Copy link
Contributor

Description

This PR aims to add support for the upcoming Equippable Components to Skript.

This will be marked as draft due to Equippable Components being ApiStatus.Experimental at this time.
Open to any syntax changes.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TheAbsolutionism TheAbsolutionism marked this pull request as draft November 4, 2024 23:19
@Efnilite Efnilite added the feature Pull request adding a new feature. label Nov 5, 2024
@TheAbsolutionism TheAbsolutionism marked this pull request as ready for review November 10, 2024 18:32
…leComponents

# Conflicts:
#	src/main/java/ch/njol/skript/Skript.java
#	src/main/resources/lang/default.lang
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sovdeeth
Copy link
Member

sovdeeth commented Dec 8, 2024

Can you explain the reasoning behind making the equippable component a new type? Why not just have all the syntaxes act on items, like you already have them doing?

@TheAbsolutionism
Copy link
Contributor Author

Can you explain the reasoning behind making the equippable component a new type? Why not just have all the syntaxes act on items, like you already have them doing?

I believe having this new type will be beneficial for storing template equippable components. I personally feel it to be more intuitive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants