-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spawn Egg Meta + EntitySnapshots #7220
base: dev/feature
Are you sure you want to change the base?
Spawn Egg Meta + EntitySnapshots #7220
Conversation
You could just merge Kenzie's branch into your own and make a secspression yourself |
|
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprEntitySnapshot.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprEntitySnapshot.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprEntitySnapshot.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprEntitySnapshot.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprEntitySnapshot.sk
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprEntitySnapshot.sk
Outdated
Show resolved
Hide resolved
…Meta # Conflicts: # src/main/resources/lang/default.lang
src/main/java/ch/njol/skript/expressions/ExprEntitySnapshot.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a very, very quick glance across the first few changes here, but looks decent in my opinion. I'm wondering if it'd be useful to have a entity -> entity snapshot converter? That way, you could, for example, set the entity snapshot that a spawn egg will spawn just by doing like, set spawn egg entity of {_spawn egg} to (random element out of all entities)
.
src/main/java/ch/njol/skript/classes/data/DefaultComparators.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprEntitySnapshot.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
Does anyone else think I should do this too? |
That could be quite convenient, though it would allow setting it to a player without any parse errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have time for an actual proper review hopefully soon, but for now just some more small things I noticed
src/main/java/ch/njol/skript/expressions/ExprEntitySnapshot.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprEntitySnapshot.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after these ones 👍
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprEntitySnapshot.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprEntitySnapshot.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprEntitySnapshot.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprEntitySnapshot.sk
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprEntitySnapshot.sk
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprSpawnEggEntity.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👍
Description
This PR aims to set the spawned entity of a spawn egg and allow creating/getting entity snapshots along with using them in EffSecSpawn
Target Minecraft Versions: any
Requirements: none
Related Issues: none