Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn Egg Meta + EntitySnapshots #7220

Open
wants to merge 21 commits into
base: dev/feature
Choose a base branch
from

Conversation

TheAbsolutionism
Copy link
Contributor

Description

This PR aims to set the spawned entity of a spawn egg and allow creating/getting entity snapshots along with using them in EffSecSpawn


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Asleeepp
Copy link
Contributor

You could just merge Kenzie's branch into your own and make a secspression yourself

@TheAbsolutionism
Copy link
Contributor Author

You could just merge Kenzie's branch into your own and make a secspression yourself

  1. I dont know how to do that
  2. Would that be efficient?

@sovdeeth sovdeeth added the feature Pull request adding a new feature. label Nov 18, 2024
Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very, very quick glance across the first few changes here, but looks decent in my opinion. I'm wondering if it'd be useful to have a entity -> entity snapshot converter? That way, you could, for example, set the entity snapshot that a spawn egg will spawn just by doing like, set spawn egg entity of {_spawn egg} to (random element out of all entities).

@TheAbsolutionism
Copy link
Contributor Author

TheAbsolutionism commented Nov 25, 2024

I'm wondering if it'd be useful to have a entity -> entity snapshot converter? ... by doing, set spawn egg entity of {_spawn egg} to (random element out of all entities).

Does anyone else think I should do this too?

@sovdeeth
Copy link
Member

I'm wondering if it'd be useful to have a entity -> entity snapshot converter? ... by doing, set spawn egg entity of {_spawn egg} to (random element out of all entities).

Does anyone else think I should do this too?

That could be quite convenient, though it would allow setting it to a player without any parse errors.
I do have some vague concerns about setting something called a "spawn egg entity" to an entity, and then the actual value NOT being an entity, but i haven't thought that through fully yet.

Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have time for an actual proper review hopefully soon, but for now just some more small things I noticed

Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after these ones 👍

Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants