Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'download' argument from Skript command #7239

Open
wants to merge 7 commits into
base: dev/feature
Choose a base branch
from

Conversation

Asleeepp
Copy link
Contributor

@Asleeepp Asleeepp commented Dec 3, 2024

Description

This PR aims to remove the redundant 'download' argument from '/skript update'
the 'download' argument did the exact same thing as the 'check' argument, so it didn't really make sense to have it, it's also misleading if it just checks instead of downloads the latest update.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

Copy link
Member

@UnderscoreTud UnderscoreTud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the lang files to reflect this change

@Efnilite Efnilite changed the base branch from master to dev/feature December 4, 2024 17:37
@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Dec 8, 2024
src/main/resources/lang/french.lang Outdated Show resolved Hide resolved
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants