-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'download' argument from Skript command #7239
Open
Asleeepp
wants to merge
7
commits into
SkriptLang:dev/feature
Choose a base branch
from
Asleeepp:patch-remove-download-argument
base: dev/feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove 'download' argument from Skript command #7239
Asleeepp
wants to merge
7
commits into
SkriptLang:dev/feature
from
Asleeepp:patch-remove-download-argument
+4
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnderscoreTud
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the lang files to reflect this change
UnderscoreTud
requested changes
Dec 3, 2024
Efnilite
reviewed
Dec 4, 2024
Efnilite
reviewed
Dec 4, 2024
Co-authored-by: Efnilite <[email protected]>
Efnilite
approved these changes
Dec 6, 2024
Efnilite
added
the
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
label
Dec 8, 2024
cheeezburga
approved these changes
Dec 13, 2024
sovdeeth
approved these changes
Dec 15, 2024
APickledWalrus
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to remove the redundant 'download' argument from '/skript update'
the 'download' argument did the exact same thing as the 'check' argument, so it didn't really make sense to have it, it's also misleading if it just checks instead of downloads the latest update.
Target Minecraft Versions: any
Requirements: none
Related Issues: none