Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BlockIgniteEvent #7252

Open
wants to merge 1 commit into
base: dev/patch
Choose a base branch
from
Open

Conversation

kyoshuske
Copy link

@kyoshuske kyoshuske commented Dec 10, 2024

Description

EDIT: i made a mistake but still this should be changed
getIgnitingBlock() returns <none> when the event cause is "FLINT_AND_STEEL" for some reason, so i changed it to getBlock()

issue occurred on:

  • skript: 2.9.2
  • engine: paper-1.21.1-122

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite changed the base branch from master to dev/patch December 10, 2024 21:41
@Efnilite Efnilite added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Dec 10, 2024
@Efnilite
Copy link
Member

Efnilite commented Dec 10, 2024

you should add a CI test for this. feel free to ask if you're not sure how to do this in the discord.
also, does this change still make the other event values return the same for other event causes?

@TheAbsolutionism
Copy link
Contributor

I'm a bit curious as to why it was made like that in the first place. The getIgnitingBlock() returns the block that caused the event-block to catch on fire. So obviously, if it was caught on fire by flint and steel it would be null.
If anything, a custom expression should've been made to use the getIgnitingBlock().
Also, there's no reason to have this event value anymore, since the super class BlockEvent has the getBlock()

@TheAbsolutionism
Copy link
Contributor

It was added 7 years ago by LimeGlass, so maybe back then, that's how it used to be? Not sure

@kyoshuske
Copy link
Author

kyoshuske commented Dec 11, 2024

I'm a bit curious as to why it was made like that in the first place. The getIgnitingBlock() returns the block that caused the event-block to catch on fire. So obviously, if it was caught on fire by flint and steel it would be null. If anything, a custom expression should've been made to use the getIgnitingBlock(). Also, there's no reason to have this event value anymore, since the super class BlockEvent has the getBlock()

my bad i didnt notice that getIgnitingBlock() returns something different than getBlock()
but still in my opinion the event-block should return the block that is getting ignited, not the block that is causing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants