Ban Entry Syntaxes #7257
Ban Entry Syntaxes #7257
Conversation
erenkarakal
added
enhancement
| private Expression<Object> banTargetExpr; // offline player or string (ip) | ||
|
|
||
| @Override | ||
| public boolean init(Expression<?>[] expressions, int matchedPattern, Kleenean isDelayed, SkriptParser.ParseResult parseResult) { |
There was a problem hiding this comment.
| public boolean init(Expression<?>[] expressions, int matchedPattern, Kleenean isDelayed, SkriptParser.ParseResult parseResult) { | |
| public boolean init(Expression<?>[] expressions, int matchedPattern, Kleenean isDelayed, ParseResult parseResult) { |
| } | ||
|
|
||
| @Override | ||
| public Class<?> @Nullable [] acceptChange(Changer.ChangeMode mode) { |
There was a problem hiding this comment.
| public Class<?> @Nullable [] acceptChange(Changer.ChangeMode mode) { | |
| public Class<?> @Nullable [] acceptChange(ChangeMode mode) { |
| @Description("Returns data about a player or IP ban. " + | ||
| "The source can be any string, but it's usually the player's name. " + | ||
| "The expiration date won't return a value if the ban is permanent.") | ||
| @Examples({"set {_player} to offlineplayer(\"Notch\", false)", |
There was a problem hiding this comment.
| @Examples({"set {_player} to offlineplayer(\"Notch\", false)", | |
| @Examples({ | |
| "set {_player} to offlineplayer(\"Notch\", false)", |
| "set {_expiration} to the date {_player}'s ban expires", | ||
| "set {_time.left} to difference between now and {_expiration}", | ||
| "set {_reason} to the reason {_player} was banned", | ||
| "send \"There is %{_time.left}% before %{_player}% gets unbanned! They were banned for '%{_reason}%'\" to player"}) |
There was a problem hiding this comment.
| "send \"There is %{_time.left}% before %{_player}% gets unbanned! They were banned for '%{_reason}%'\" to player"}) | |
| "send \"There is %{_time.left}% before %{_player}% gets unbanned! They were banned for '%{_reason}%'\" to player" | |
| }) |
| if (Skript.methodExists(BanEntry.class, "remove")) | ||
| Skript.registerExpression(ExprBanData.class, Object.class, ExpressionType.SIMPLE, | ||
| "[the] date %offlineplayer/string% was banned", | ||
| "[the] date of %offlineplayer/string%'s ban", |
There was a problem hiding this comment.
%offlineplayer/string%'[s] ban date?
| } | ||
|
|
||
| @Override | ||
| public void change(Event event, Object @Nullable [] delta, Changer.ChangeMode mode) { |
There was a problem hiding this comment.
| public void change(Event event, Object @Nullable [] delta, Changer.ChangeMode mode) { | |
| public void change(Event event, Object @Nullable [] delta, ChangeMode mode) { |
| static { | ||
| if (Skript.methodExists(BanEntry.class, "remove")) | ||
| Skript.registerExpression(ExprBanData.class, Object.class, ExpressionType.SIMPLE, | ||
| "[the] date %offlineplayer/string% was banned", |
There was a problem hiding this comment.
Syntax is not a good option, it can be very confusing for readers and might affect the parser. I suggest something like ban date of ... as Efnilite also suggested.
Same goes for the rest of syntaxes, ban X of Y
There was a problem hiding this comment.
This current one seems much better than ban x of y to me.
Is there a reason you think it's poor?
There was a problem hiding this comment.
date "SkriptDev" was banned seems off to me at first glance, it doesn't immediately gives you a hint that it's a ban date. IMO ban date is easier to quickly recognize it's a ban date.
There was a problem hiding this comment.
I think it'd be improved by adding that:
the date that "SkriptDev" was banned
It buries the lead by like 2 words which i don't really think is an issue, especially when it's so much more natural/fluid imo. ban date of "SkriptDev" feels much more stilted and awkward and something i wouldn't actually say irl.
I'm not opposed to having it in addition, but i definitely think the current syntax is higher quality
There was a problem hiding this comment.
so do i add another syntax for ban date or ..?
Co-authored-by: Efnilite <[email protected]>
Description
This PR lets you get details about player/IP bans, such as the date the ban was issued, who banned them, the expiration date, and the reason for the ban.
You can set/add/remove from the expiration date and set the source/reason. You can technically set the ban creation date but I didn't include it in the PR.
Examples
Target Minecraft Versions: 1.20.1+
Requirements: none
Related Issues: none