Vehicle Events #7260
Open
Vehicle Events #7260
+238
−233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
requested changes
Dec 14, 2024
src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Dec 14, 2024
…vents # Conflicts: # src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
sovdeeth
requested changes
Dec 15, 2024
Comment on lines
+20
to
+21
| Skript.registerEvent("Vehicle Collision", EvtVehicleCollision.class, new Class[]{VehicleBlockCollisionEvent.class, VehicleEntityCollisionEvent.class} | ||
| ,"vehicle collision [(with|of) [a[n]] %-itemtypes/blockdatas/entitydatas%]", |
There was a problem hiding this comment.
Suggested change
| Skript.registerEvent("Vehicle Collision", EvtVehicleCollision.class, new Class[]{VehicleBlockCollisionEvent.class, VehicleEntityCollisionEvent.class} | |
| ,"vehicle collision [(with|of) [a[n]] %-itemtypes/blockdatas/entitydatas%]", | |
| Skript.registerEvent("Vehicle Collision", EvtVehicleCollision.class, new Class[]{VehicleBlockCollisionEvent.class, VehicleEntityCollisionEvent.class}, | |
| "vehicle collision [(with|of) [a[n]] %-itemtypes/blockdatas/entitydatas%]", |
| if (args[0] != null) { | ||
| expr = args[0]; | ||
| types = args[0].getArray(); | ||
| blockSpecific = !(types instanceof EntityData<?>[]); |
There was a problem hiding this comment.
this isn't safe, what if it's a mixed input of blocks and entities?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add additional Vehicle Events
Target Minecraft Versions: any
Requirements: none
Related Issues: none